Correct bug in DirectFactorsOfGroup #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stupid mistake: instead of "(A or B) and C", there was "A or B and C", which evaluated true instead of false for A=true and C=false.
|
This looks good to me, and I'd be keen to merge soon, since this fixes a bug that causes a wrong result. |
|
To me too, so I am merging this now. The fix in the test teaches a lesson that you that when the test created from the output is passing, that does not always mean that that output is correct :) |
olexandr-konovalov
pushed a commit
that referenced
this pull request
Feb 1, 2016
Correct bug in DirectFactorsOfGroup
|
@alex-konovalov Fair enough, duly noted. |
olexandr-konovalov
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stupid mistake: instead of
(A or B) and C, there wasA or B and C,which evaluated
trueinstead offalseforA=trueandC=false.This was a bug was introduced in #379, and reported by @alex-konovalov there after the merge.